Skip to content

Conversation

@IngramBJ
Copy link
Contributor

@IngramBJ IngramBJ commented Oct 30, 2025

replace ensure_clean with temp_file in pandas/tests/io/sas/test_sas.py
What:
Replace tm.ensure_clean usage with the pytest temp_file fixture in
pandas/tests/io/sas/test_sas.py.

Why:
The project standard is to use the temp_file pytest fixture instead of the
legacy ensure_clean helper. This is one small PR toward #62435.

Changes:

  • test_sas_read_no_format_or_extension: changed signature to accept temp_file
    and pass temp_file directly to read_sas().

Local verification:

  • Ran the file tests locally:
    pytest -q pandas/tests/io/sas/test_sas.py
    pytest -q pandas/tests/io/sas/test_sas.py::TestSas::test_sas_read_no_format_or_extension
  • Pre-commit hooks:
    pre-commit run --all-files

Notes:

Related:

replace ensure_clean with temp_file in pandas/tests/io/sas/test_sas.py
@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Oct 30, 2025
@mroeschke mroeschke added this to the 3.0 milestone Oct 30, 2025
@mroeschke mroeschke merged commit 6e42b1f into pandas-dev:main Oct 30, 2025
44 of 47 checks passed
@mroeschke
Copy link
Member

Thanks @IngramBJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants